rustc: use Name numbers rather than the Show impl for constants. #16213
+38
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This fixes ... #15799 ? I could have sworn there was another issue filed for this but I cannot find it. |
Contributor
|
The PR itself looks good, feel free to r=me after doing some due diligence looking for issues to tag as closed with this. |
Contributor
Author
|
It does appear to fix that one (nice catch, I'd completely forgotten about that issue), but I can't find any others. |
Contributor
|
@pnkfelix This looks related to my recent #16153, which fixed this same issue for a bunch of other things. FWIW you could switch to using |
Using the Show impl for Names created global symbols with names like `"str\"str\"(1027)"`. This adjusts strings, binaries and vtables to avoid using that impl. Fixes rust-lang#15799.
bors
added a commit
that referenced
this pull request
Aug 4, 2014
Using the Show impl for Names created global symbols with names like `"str\"str\"(1027)"`. This adjusts strings, binaries and vtables to avoid using that impl.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 8, 2024
…cola chore: update docs/dev/guide.md based on 2024-01-01 release Updates dev guide based on 2024-01-01 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the Show impl for Names created global symbols with names like
"str\"str\"(1027)". This adjusts strings, binaries and vtables toavoid using that impl.